Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/script #706

Open
wants to merge 1 commit into
base: refactoring/script
Choose a base branch
from
Open

Refactoring/script #706

wants to merge 1 commit into from

Conversation

perlpilot
Copy link
Contributor

I've added the -t/--template option to Dancer::Script and updated script/dancer with some usage information.

@xsawyerx
Copy link
Member

xsawyerx commented Dec 1, 2011

That's awesome work, thank you!!

Why did you change the template variable syntax to [[ and ]]?

@perlpilot
Copy link
Contributor Author

My thinking was that the files within the application template directory may have their own template delimiters (in the "view" files) that may conflict with [% and %] since they are so common and I didn't want the process of generating the application dir from the application template to to accidentally interfere with those files. (i.e. for some files there are two levels of templating, one to create the application dir and the other for application itself)

Perhaps that's a tad overly paranoid though.

@bigpresh
Copy link
Member

Just wanted to make it clear that this isn't being ignored; we're aware of the PR, and I plan to review, test and merge as soon as time permits. A lot of effort is going towards Dancer2, but we obviously still want to maintain and improve Dancer until such time as Dancer2 is ready for a stable release :)

@xsawyerx
Copy link
Member

I'll try to conduct a triage today. If I get around to it, I might merge this in, in a few hours.
This is definitely not being ignored and thanks for the ping! :)

@sukria
Copy link
Member

sukria commented Mar 23, 2012

OK so first review:

  • This includes the full work of Carlos, are we sure everything was done entirely there?

  • I'm experiencing a bug here:

    $ perl -Ilib ./script/dancer -a TestFoo
    debug> Writing directory: TestFoo
    debug> Successfully wrote the directory: TestFoo
    Can't locate object method "_jquery_minified" via package "Dancer::Script" at lib/Dancer/Script.pm line 469.

@bigpresh
Copy link
Member

... sorry this has waited so long. This is something we should definitely incorporate in Dancer2.

We're mostly focussing new features on D2 these days, but since this has waited ages as a PR ready to merge, if the issue sukria saw is fixed, I think we should merge it anyway. Thoughts, guys?

@xsawyerx
Copy link
Member

There's a branch with all of this work relatively recently rebased. Check that out.

@mokko
Copy link
Contributor

mokko commented Apr 3, 2013

Yanick just merged the branch Sawyer mentions above into devel, so if I am not mistaken this issue can be closed.

EDIT: I was mistaken and this PR with application templates is not yet included. So it's good that issue is not closed. Should it be merged at all? With or without [[ ]] is not quite clear from this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants